target_dependency: Fix crash if target_proxy is nil.
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide more info about the failure case? Also what about a test? |
byohay
force-pushed
the
feature/fix-target-dependency-crash
branch
from
4bcdcb2
to
079bd2f
Compare
If `target_proxy` is `nil`, calling `to_tree_hash` on it will raise an exception: undefined method `to_tree_hash' for nil:NilClass (NoMethodError).
byohay
force-pushed
the
feature/fix-target-dependency-crash
branch
from
079bd2f
to
0303c0b
Compare
|
@dnkoutso sorry, added a test and explanation. |
amorde
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
target_proxyisnil, callingto_tree_hashon it will raise anexception: undefined method `to_tree_hash' for nil:NilClass
(NoMethodError).